[
https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240823#comment-13240823
]
Phabricator commented on HIVE-2908:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-2908 [jira] Hive: Extend ALTER
TABLE DROP PARTITION syntax to use all comparators".
Looks good, just some cosmetic things.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java:61 Why do you
change the != to <>, why not use whichever the user chose to use?
ql/src/test/results/clientnegative/drop_partition_filter_failure.q.out:18
This error message seems confusing, the filter was < 1, so it should not be
surprising that the partition '1' was not found. (I know why this exception
was thrown, I'm just saying the message could be improved)
ql/src/test/queries/clientpositive/drop_partitions_filter.q:18 Out of
curiosity, does the behavior change if you use d<=2 vs. d<='2'?
REVISION DETAIL
https://reviews.facebook.net/D2523
> Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
> ---------------------------------------------------------------------
>
> Key: HIVE-2908
> URL: https://issues.apache.org/jira/browse/HIVE-2908
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Sambavi Muthukrishnan
> Assignee: Sambavi Muthukrishnan
> Priority: Minor
> Attachments: HIVE-2908.D2523.1.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> To drop a partition from a Hive table, this works:
> ALTER TABLE foo DROP PARTITION(ds = 'date')
> ...but it should also work to drop all partitions prior to date.
> ALTER TABLE foo DROP PARTITION(ds < 'date')
> This task is to implement ALTER TABLE DROP PARTITION for all of the
> comparators, < > <= >= <> = != instead of just for =.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
