[ 
https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239210#comment-13239210
 ] 

Phabricator commented on HIVE-2898:
-----------------------------------

ashutoshc has requested changes to the revision "HIVE-2898 [jira] Add nicer 
helper functions for adding and reading metadata from RCFiles".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:545 Should this be named 
createMetaData()?
  ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:1215 This is not 
returning string to string map, rather just Text.
  ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:1219 Should this be 
named getMetadataValueOf() ?

REVISION DETAIL
  https://reviews.facebook.net/D2433

BRANCH
  h-2898

                
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
>                 Key: HIVE-2898
>                 URL: https://issues.apache.org/jira/browse/HIVE-2898
>             Project: Hive
>          Issue Type: New Feature
>          Components: Serializers/Deserializers
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, 
> HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using 
> SequenceFile.Metadata. I'd like to add two helper functions that make it more 
> convenient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to