[ 
https://issues.apache.org/jira/browse/HIVE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238964#comment-13238964
 ] 

Phabricator commented on HIVE-2907:
-----------------------------------

mousom has commented on the revision "HIVE-2907 [jira] Hive error when dropping 
a table with large number of partitions".

  May I modify the drop_table_failure3.q test itself to do that? That might 
serve both purposes.

INLINE COMMENTS
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:164 
Can you please make this a separate task Kevin?

  Thanks
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:292 like the *.q 
file I added?
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:544 
yup
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:1997 
my bad. done.
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:292 i will add both 
in *.q files.
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1399 I 
thought about it but it's just intuitively does not make sense if we return 
'ALL' when 0 is passed.And it might be a very difficult to catch bug for a 
client.But, on the other hand, you are right that this change might break 
existing clients and that has to be avoided, so I guess I will make this bug a 
feature :-)

REVISION DETAIL
  https://reviews.facebook.net/D2505

                
> Hive error when dropping a table with large number of partitions
> ----------------------------------------------------------------
>
>                 Key: HIVE-2907
>                 URL: https://issues.apache.org/jira/browse/HIVE-2907
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.9.0
>         Environment: General. Hive Metastore bug.
>            Reporter: Mousom Dhar Gupta
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2907.1.patch.txt, HIVE-2907.D2505.1.patch, 
> HIVE-2907.D2505.2.patch, HIVE-2907.D2505.3.patch
>
>   Original Estimate: 10h
>  Remaining Estimate: 10h
>
> Running into an "Out Of Memory" error when trying to drop a table with 128K 
> partitions.
> The methods dropTable in 
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> and dropTable in ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
> encounter out of memory errors 
> when dropping tables with lots of partitions because they try to load the 
> metadata for every partition into memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to