[
https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2838:
------------------------------
Attachment: HIVE-2838.D2193.1.patch
njain requested code review of "HIVE-2838 [jira] cleanup
readentity/writeentity".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2838
HIVE-2838 Cleaup read/write Entities
Ideally, there should be one common entity instead of readentity/writeentity.
Unfortunately, that would be a backward incompatible change since users os
hive might have written
there own hooks, where they are using readentity/writeentity.
We should atleast create a common class, and then we can deprecate read/write
entity later, for a new release.
For now, I propose to make a backward compatible change.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2193
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java
ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4815/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> cleanup readentity/writeentity
> ------------------------------
>
> Key: HIVE-2838
> URL: https://issues.apache.org/jira/browse/HIVE-2838
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2838.D2193.1.patch
>
>
> Ideally, there should be one common entity instead of readentity/writeentity.
> Unfortunately, that would be a backward incompatible change since users os
> hive might have written
> there own hooks, where they are using readentity/writeentity.
> We should atleast create a common class, and then we can deprecate read/write
> entity later, for a new release.
> For now, I propose to make a backward compatible change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
