[
https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221331#comment-13221331
]
Phabricator commented on HIVE-2833:
-----------------------------------
enis has commented on the revision "HIVE-2833 [jira] Fix test failures caused
by HIVE-2716".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java:1019
What is class1 is used for? I noticed that you did not change it but just moved
the method. Shall we remove that parameter.
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:49
Changing this to DummyJdoConnectionUrlHook.class.getName() will be better for
refactoring / finding references.
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:53
same here
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:32
There is a separate test for the metastorehook in
contrib/src/test/queries/clientnegative/url_hook.q and
contrib/src/java/org/apache/hadoop/hive/contrib/metastore/hooks/TestURLHook.java,
which tests the meta store hook connection retry mechanism. Shall we also
migrate that test here, wdyt?
Please see that patch at https://reviews.facebook.net/D1953
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java:33
Can you remove this, it is not used.
REVISION DETAIL
https://reviews.facebook.net/D2055
> Fix test failures caused by HIVE-2716
> -------------------------------------
>
> Key: HIVE-2833
> URL: https://issues.apache.org/jira/browse/HIVE-2833
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Carl Steinbach
> Assignee: Kevin Wilfong
> Attachments: HIVE-2716.D2055.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
