[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212268#comment-13212268 ]
Phabricator commented on HIVE-2792: ----------------------------------- ashutoshc has requested changes to the revision "HIVE-2792 [jira] SUBSTR(CAST(<string> AS BINARY)) produces unexpected results". Patch looks good. Can you update the testcase as I noted so that we have better coverage? INLINE COMMENTS ql/src/test/results/clientpositive/ba_table_udfs.q.out:28 For a better test so that it captures variance in the rows, modify the test in ba_tables_udfs.q to SUBSTR(src.value AS BINARY), 3), SUBSTR(src.value AS BINARY), -4,3) REVISION DETAIL https://reviews.facebook.net/D1797 BRANCH DPAL-848 > SUBSTR(CAST(<string> AS BINARY)) produces unexpected results > ------------------------------------------------------------ > > Key: HIVE-2792 > URL: https://issues.apache.org/jira/browse/HIVE-2792 > Project: Hive > Issue Type: Bug > Components: UDF > Reporter: Carl Steinbach > Attachments: HIVE-2792.D1797.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira