[
https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209984#comment-13209984
]
Phabricator commented on HIVE-2716:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2716 [jira] Move retry
logic in HiveMetaStore to a separe class".
INLINE COMMENTS
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:136
Is this change required, or are you just providing coverage for the new
dropType(String, boolean) method? Were exceptions somehow getting masked
earlier?
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingRawStore.java:38
It's not clear to me why HCatalog needs access to this class. Can you please
provide more details?
REVISION DETAIL
https://reviews.facebook.net/D1227
BRANCH
ms-retry-logic
> Move retry logic in HiveMetaStore to a separe class
> ---------------------------------------------------
>
> Key: HIVE-2716
> URL: https://issues.apache.org/jira/browse/HIVE-2716
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HIVE-2716.D1227.1.patch, HIVE-2716.D1227.2.patch
>
>
> In HIVE-1219, method retrying for raw store operation are introduced to
> handle jdo operations more robustly. However, the abstraction for the
> RawStore operations can be moved to a separate class implementing RawStore,
> which should clean up the code base for HiveMetaStore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
