[ https://issues.apache.org/jira/browse/HIVE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2261: ------------------------------ Attachment: HIVE-2261.D1329.2.patch navis updated the revision "HIVE-2261 [jira] Add cleanup stages for UDFs". Reviewers: JIRA Changed init method signiture of ExprNodeEvaluator to accept configuration instance. But it is non-null only in the Mapred task and close method also is called only in that. REVISION DETAIL https://reviews.facebook.net/D1329 AFFECTED FILES hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeNullEvaluator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ExtractOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java ql/src/test/org/apache/hadoop/hive/ql/exec/TestExpressionEvaluator.java ql/src/test/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestClose.java ql/src/test/queries/clientnegative/udf_close.q ql/src/test/queries/clientpositive/udf_close.q ql/src/test/results/clientnegative/udf_close.q.out ql/src/test/results/clientpositive/udf_close.q.out > Add cleanup stages for UDFs > --------------------------- > > Key: HIVE-2261 > URL: https://issues.apache.org/jira/browse/HIVE-2261 > Project: Hive > Issue Type: Wish > Components: Query Processor > Reporter: Navis > Assignee: Navis > Priority: Trivial > Attachments: HIVE-2261.D1329.1.patch, HIVE-2261.D1329.2.patch > > > In some cases, we bind values at last stage of big SQL from other sources, > especially from memcached. I made that kind of UDFs for internal-use. > I found 'initialize' method of GenericUDF class is good place for making > connections to memcached cluster, but failed to find somewhere to > close/cleanup the connections. If there is cleaup method in GenericUDF class, > things can be more neat. If initializing entity like map/reduce/fetch could > be also providable to life-cycles(init/close), that makes perfect. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira