Hi Eshwitha, That PR has a "continuously" failing test in the CI: TestEncryptedHDFSCliDriver and you have modified the code around HDFS & Encryption only. I saw you had a comment on the ticket that it passes for you locally, but thats not how we can push it forward, you need to get a green build.
Just had a quick pass, with my limited HDFS knowledge, I think that code is conceptually wrong as well though it is fixing one of your use cases, this seems to be treating if the path doesn't exist, it ain't encrypted... Unfortunately, I don't have enough bandwidth to fix the logic or help debug the test failure anytime soon. AFAIK we don't officially support ViewFs either in Hive now, there are issues with that atleast in Hive-4.x, when you will be operating cross mounts and maybe some more if someone tests that thoroughly!!! -Ayush On Mon, 12 Aug 2024 at 01:10, Eshwitha Sai <saieshwitha...@gmail.com> wrote: > > Hi all, > > This is a review request for the patch Github Pull Request #5137 related to > HIVE-28118. > The patch has an LGTM (from deniskuzZ) and is waiting for further review > (from ayushtkn) > > Kindly review the same. > > Thanks & Regards, > Eshwitha Sai.
