Thanks for the feedback Stamatis!
As discussed offline:
I will close this vote as unsuccessful
I will create a new release candidate with the
derby.log/metastore_db/${test.tmp.dir} removed, but keep the other things
unchanged
I have created jiras to fix the other issues in the next release:
HIVE-26070: Remove the generated files from the source tarball
HIVE-26069: Remove unnecessary items from the .gitignore
HIVE-26068: Add README to the src tarball
HIVE-26067: Remove core directory from src
So I close this vote as unsuccessful.
Thanks,
Peter
> On 2022. Mar 23., at 23:26, Stamatis Zampetakis <zabe...@gmail.com> wrote:
>
> Ubuntu 20.04.4 LTS, jdk1.8.0_261, Apache Maven 3.6.3
>
> * Checked signatures and checksums OK
> * Checked diff between repo and release sources (diff -qr hive
> apache-hive-4.0.0-alpha-1-src) KO
> * Built from git tag (mvn clean install -DskipTests -Pitests) OK
> * Built from release sources (mvn clean install -DskipTests -Pitests) OK
>
> While comparing the content of the git repo with the release sources I
> noticed various differences. Most notable ones for which I cast a negative
> vote are listed below:
>
> Only in apache-hive-4.0.0-alpha-1-src/common/src: gen
> Only in apache-hive-4.0.0-alpha-1-src/conf: hive-default.xml.template
> Only in apache-hive-4.0.0-alpha-1-src/itests/hive-unit: cmroot
> Only in apache-hive-4.0.0-alpha-1-src/ql: dependency-reduced-pom.xml
> Only in
> apache-hive-4.0.0-alpha-1-src/standalone-metastore/metastore-common/src/gen:
> version
> Only in
> apache-hive-4.0.0-alpha-1-src/standalone-metastore/metastore-server:
> derby.log
> Only in
> apache-hive-4.0.0-alpha-1-src/standalone-metastore/metastore-server:
> metastore_db
> Only in
> apache-hive-4.0.0-alpha-1-src/standalone-metastore/metastore-server/src: gen
> Only in apache-hive-4.0.0-alpha-1-src/streaming: ${test.tmp.dir}
> Only in hive/: README.md
> Only in hive/: core
>
> The fact that derby.log and metastore_db appears in the released sources
> it's definitely not normal.
>
> Other than that I was surprised to see that itests sources are part of the
> released sources. I thought that the goal of keeping them separate was to
> avoid releasing them along with the main code. I checked previous releases
> and the directory is there so I suppose it is intentional to have them in
> apache-hive-4.0.0-alpha-1-src.tar.gz
>
> For future votes, I think it is useful to include in the email a pointer to
> the PGP key that was used to sign the release. I knew where to find it but
> not sure if everyone does. I have to note that the key that was used to
> sign the release does not seem to be signed by any other member of the PMC;
> this is a bit problematic but not a blocker [1].
>
> Last, I've seen that the released sources do not contain a README file with
> instructions or pointers on how to build the project.
>
> -1 (non-binding)
>
> Best,
> Stamatis
>
> [1] https://www.apache.org/info/verification.html
>
>
> On Wed, Mar 23, 2022 at 11:45 AM Peter Vary <pv...@cloudera.com.invalid>
> wrote:
>
>> Hi Stamatis,
>>
>> Here is the data you have suggested:
>> Commit hash: 357d4906f5c806d585fd84db57cf296e12e6049b
>> Checksums:
>> ff60286044d2f3faa8ad1475132cdcecf4ce9ed8faf1ed4e56a6753ebc3ab585
>> apache-hive-4.0.0-alpha-1-bin.tar.gz
>> 07f30371df5f624352fa1d0fa50fd981a4dec6d4311bb340bace5dd7247d3015
>> apache-hive-4.0.0-alpha-1-src.tar.gz
>>
>> Also added it to the
>> https://cwiki.apache.org/confluence/display/Hive/HowToRelease <
>> https://cwiki.apache.org/confluence/display/Hive/HowToRelease> wiki page
>> as well
>>
>> Thanks,
>> Peter
>>
>>> On 2022. Mar 22., at 18:22, Stamatis Zampetakis <zabe...@gmail.com>
>> wrote:
>>>
>>> Hi Peter,
>>>
>>> Many thanks for rolling out the RC and for resolving many of the blocker
>>> issues that were remaining.
>>>
>>> In general, it is a good practice to include the commit hash (which tags
>>> the release) and the checksum hashes of the release artifacts [1] in the
>>> vote email to minimize the chances of man-in-the-middle attacks and
>> voting
>>> on wrong packages.
>>> Can you please update this thread with those?
>>>
>>> Best,
>>> Stamatis
>>>
>>> [1] https://people.apache.org/~pvary/apache-hive-4.0.0-alpha-1-rc1/
>>>
>>>
>>> On Tue, Mar 22, 2022 at 5:00 PM Naveen Gangam
>> <ngan...@cloudera.com.invalid>
>>> wrote:
>>>
>>>> I have been able to build and run a quick test. I have NOT verified the
>>>> signature. I was trying to run the HMS Checkin tests and got this. I
>>>> suspect these are not specific to the alpha-1 branch. But it is not a
>> test
>>>> failure (although it appears like it should be)
>>>> *"mvn test
>>>>
>>>>
>> -Dtest.groups=org.apache.hadoop.hive.metastore.annotation.MetastoreCheckinTest"*
>>>>
>>>> [*INFO*] Running
>> org.apache.hadoop.hive.common.metrics.*TestLegacyMetrics*
>>>>
>>>> [main] WARN org.apache.hadoop.hive.common.metrics.LegacyMetrics - Could
>> not
>>>> find counter value for foo.n, returning null instead.
>>>>
>>>> javax.management.AttributeNotFoundException: Key [foo.n] not
>> found/tracked
>>>>
>>>> at
>>>>
>>>>
>> org.apache.hadoop.hive.common.metrics.MetricsMBeanImpl.getAttribute(MetricsMBeanImpl.java:56)
>>>>
>>>>
>>>> [*WARNING*] *Tests **run: 18*, Failures: 0, Errors: 0, *Skipped: 2*,
>> Time
>>>> elapsed: 4.158 s - in
>>>> org.apache.hadoop.hive.metastore.client.*TestCatalogs*
>>>>
>>>> [*INFO*] Running org.apache.hadoop.hive.metastore.*TestMarkPartition*
>>>>
>>>> [*INFO*] *Tests run: 1*, Failures: 0, Errors: 0, Skipped: 0, Time
>> elapsed:
>>>> 15.021 s - in org.apache.hadoop.hive.metastore.*TestMarkPartition*
>>>>
>>>> [*INFO*]
>>>>
>>>> [*INFO*] Results:
>>>>
>>>> [*INFO*]
>>>>
>>>> [*WARNING*] *Tests run: 2182, Failures: 0, Errors: 0, Skipped: 5*
>>>>
>>>>
>>>> So over no test failures.
>>>>
>>>> +1 pending other votes (& non-binding)
>>>>
>>>> Thank you
>>>> Naveen
>>>>
>>>> On Tue, Mar 22, 2022 at 9:32 AM Marton Bod <m...@cloudera.com.invalid>
>>>> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>> Tested the checksums, signatures and built it successfully
>>>>>
>>>>> On Tue, Mar 22, 2022 at 2:26 PM Peter Vary <pv...@cloudera.com.invalid
>>>
>>>>> wrote:
>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>> Apache Hive 4.0.0-alpha-1 Release Candidate 1 is available here:
>>>>>>
>>>>>> https://people.apache.org/~pvary/apache-hive-4.0.0-alpha-1-rc1/
>>>>>>
>>>>>> Maven artifacts are available here:
>>>>>>
>>>>>>
>> https://repository.apache.org/content/repositories/orgapachehive-1111/
>>>>>>
>>>>>> The tag 4.0.0-alpha-1-rc1 has been applied to the source for this
>>>> release
>>>>>> in github, you can see it at
>>>>>> https://github.com/apache/hive/tree/release-4.0.0-alpha-1-rc1
>>>>>>
>>>>>> Voting will conclude in 72 hours.
>>>>>>
>>>>>> All interested parties: Please test.
>>>>>> Hive PMC Members: Please test and vote.
>>>>>>
>>>>>> Thanks.
>>>>>
>>>>
>>
>>
