If I remember correctly the decision was to not to merge changes with failing 
PreCommit tests.

Lately, because of a mistake where the change was only partially merged, we had 
a failing test.
I have tried to fix this issue and confirm it by rerunning the tests, but the 
check failed again. Now it failed with some different tests, because in the 
meantime there were some more failing tests were committed to master in the 
meantime.

I think it would be good to stick to the previous decision and we should only 
commit changes if all of the tests are green. Also if there are some issues 
then it would be good to take the time to fix the failures or revert the 
changes causing the issues.

Thanks,
Peter


Reply via email to