Hey David, Yes we probably need to switch to OpenJDK -- latest PR seems on the right track (https://github.com/kgyrtkirk/hive-dev-box/pull/6)
Regarding testing one way to go would be: 1) populate your own Docker Image based on the above executor with jdk11 support 2) update your hive clone repo Jenkins file to use the populated executor 3) use a test precommit with your hive clone repo to discover any issues (created this in the past, feel free to use: http://ci.hive.apache.org/job/panos-precommit/) Cheers, Panagiotis On Mon, Jul 13, 2020 at 3:57 PM David <dam6...@gmail.com> wrote: > Hey Panos, > > Thanks so much! > > I put in a PR with what I THINK is the correct version, but I don't have a > way to test this. > > https://github.com/kgyrtkirk/hive-dev-box/pull/5/files > > Having just stumbled on this, I'm not sure that Hive should be building > with zulu as most folks run on OpenJDK or Oracle. > > Thanks. > > On Mon, Jul 13, 2020 at 10:44 AM Panos Garefalakis <panga...@gmail.com> > wrote: > > > Hey David, > > > > The current CI process is using a pre-populated docker image for running > > the tests: https://hub.docker.com/r/kgyrtkirk/hive-dev-box/tags > > The image is build based on the sources located here: > > > > > https://github.com/kgyrtkirk/hive-dev-box/blob/master/tools/install_sdk.bash > > So I believe first we have to include java 11 as part of the image setup > -- > > could you open a PR for java 11 there? > > > > Cheers, > > Panagiotis > > > > > > On Mon, Jul 13, 2020 at 3:22 PM David <dam6...@gmail.com> wrote: > > > > > Hello Gang, > > > > > > I am working on getting Hive to build on OpenJDK 11 (PR #1241) > > > > > > When Jenkins runs it, the build fails and I get an "Fatal error > > compiling: > > > invalid target release: 11" which means that it is using an older > JDK. I > > > looked at the build logs and see that JAVA_HOME is set to, what appears > > to > > > be, JDK 8. > > > > > > /usr/lib/jvm/zulu-8-amd64/ > > > > > > Is there any way to change this with my PR or does this require some > > > fidgeting with the entire CI process? > > > > > > > > > [2020-07-11T06:06:52.274Z] + . /etc/profile.d/confs.sh > > > [2020-07-11T06:06:52.274Z] ++ export MAVEN_OPTS=-Xmx2g > > > [2020-07-11T06:06:52.274Z] ++ MAVEN_OPTS=-Xmx2g > > > [2020-07-11T06:06:52.274Z] ++ export HADOOP_CONF_DIR=/etc/hadoop > > > [2020-07-11T06:06:52.274Z] ++ HADOOP_CONF_DIR=/etc/hadoop > > > [2020-07-11T06:06:52.274Z] ++ export HADOOP_LOG_DIR=/data/log > > > [2020-07-11T06:06:52.274Z] ++ HADOOP_LOG_DIR=/data/log > > > [2020-07-11T06:06:52.274Z] ++ export > > > > 'HADOOP_CLASSPATH=/etc/tez/:/active/tez/lib/*:/active/tez/*:/apps/lib/*' > > > [2020-07-11T06:06:52.274Z] ++ > > > > HADOOP_CLASSPATH='/etc/tez/:/active/tez/lib/*:/active/tez/*:/apps/lib/*' > > > [2020-07-11T06:06:52.274Z] ++ export HIVE_CONF_DIR=/etc/hive/ > > > [2020-07-11T06:06:52.274Z] ++ HIVE_CONF_DIR=/etc/hive/ > > > [2020-07-11T06:06:52.274Z] ++ export > JAVA_HOME=/usr/lib/jvm/zulu-8-amd64/ > > > [2020-07-11T06:06:52.274Z] ++ JAVA_HOME=/usr/lib/jvm/zulu-8-amd64/ > > > > > > > > > Thanks. > > > > > >
