[ 
https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2714:
------------------------------

    Attachment: HIVE-2714.D1239.1.patch

jonchang requested code review of "HIVE-2714 [jira] Lots of special characters 
are not handled in LIKE".
Reviewers: JIRA

  HIVE-2714

  Currently LIKE converts the string to a regular expression.  It tries to 
handle special characters but many are not correctly handled, e.g. +, ?, |, 
etc.  That code should just use Pattern.quote.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D1239

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java
  ql/src/test/queries/clientpositive/udf_like.q
  ql/src/test/results/clientpositive/udf_like.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/2541/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Lots of special characters are not handled in LIKE
> --------------------------------------------------
>
>                 Key: HIVE-2714
>                 URL: https://issues.apache.org/jira/browse/HIVE-2714
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>         Attachments: HIVE-2714.D1239.1.patch
>
>
> Currently LIKE converts the string to a regular expression.  It tries to 
> handle special characters but many are not correctly handled, e.g. +, ?, |, 
> etc.  That code should just use Pattern.quote.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to