----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72553/ -----------------------------------------------------------
(Updated máj. 28, 2020, 8:58 de) Review request for hive, Karen Coppage and Laszlo Pinter. Changes ------- Reworked the tests. Removed unused looped parameter from MetastoreThreads Made sure that the end of new the tests the Worker is stopped. Bugs: HIVE-23555 https://issues.apache.org/jira/browse/HIVE-23555 Repository: hive-git Description ------- Run the actual execution in a new thread, and use Future.get with timeout Diffs (updated) ----- hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 569de706df itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorTestUtil.java e70d8783bc itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 32fe535b2b ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java ecaad509ed ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 5fa3d9ad42 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThread.java b378d40964 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java fa2ede3738 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java aa258b331f ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/RemoteCompactorThread.java 4235184fec ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java 8180adcd66 ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java 366282a30f ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java 3ff68a3c7e ql/src/test/org/apache/hadoop/hive/ql/stats/TestStatsUpdaterThread.java 84827d1604 ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java 9a9ab53fcc ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java 443f982d66 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java e20fdaf03d standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreThread.java ea6155200c streaming/src/test/org/apache/hive/streaming/TestStreaming.java 6101caac66 Diff: https://reviews.apache.org/r/72553/diff/2/ Changes: https://reviews.apache.org/r/72553/diff/1-2/ Testing ------- Created unit tests to check the timeout functionality. Thanks, Peter Vary