> On May 18, 2020, 11:45 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveCardinalityPreservingJoinOptimization.java > > Lines 325 (patched) > > <https://reviews.apache.org/r/72526/diff/1/?file=2232534#file2232534line325> > > > > Do you need to override this method? > > Krisztian Kasa wrote: > I only add collecting the `HiveTableScan` instances in order to copy them > when the Join operators created.
Removed the override and create the new HiveTableScan from RelOptHiveTable. - Krisztian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72526/#review220811 ----------------------------------------------------------- On May 26, 2020, 6:29 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72526/ > ----------------------------------------------------------- > > (Updated May 26, 2020, 6:29 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-23493 > https://issues.apache.org/jira/browse/HIVE-23493 > > > Repository: hive-git > > > Description > ------- > > Rewrite plan to join back tables with many projected columns joined multiple > times > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8094d28f21 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveCardinalityPreservingJoinOptimization.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveCardinalityPreservingJoinRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java > 19ce3ea223 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 377e8280e5 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query11.q.out > 0136ee4bb5 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query4.q.out > 987a0f348e > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query74.q.out > 289e5d2569 > > > Diff: https://reviews.apache.org/r/72526/diff/4/ > > > Testing > ------- > > mvn test -Dtest.output.overwrite -DskipSparkTests > -Dtest=TestMiniLlapLocalCliDriver > -Dqfile=cardinality_preserving_join_opt.q,cardinality_preserving_join_opt_q4.q,cardinality_preserving_join_opt_q11.q,cardinality_preserving_join_opt_q74.q > -pl itests/qtest -Pitests > > > Thanks, > > Krisztian Kasa > >
