----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/#review220824 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Line 10130 (original), 10130 (patched) <https://reviews.apache.org/r/72480/#comment309535> Could be please add a javadoc comment here. I think it is especially important as startedBackGroundThreads is a test only parameterer. (maybe rename to startedBackgroundThread) standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 10468 (patched) <https://reviews.apache.org/r/72480/#comment309536> nit: extra space standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java Lines 234 (patched) <https://reviews.apache.org/r/72480/#comment309537> Question: Is this log line printed when the HMS is started, but the threads are not yet stated? Maybe extend the log line with this info? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java Lines 242 (patched) <https://reviews.apache.org/r/72480/#comment309539> Question: Is this again the case when the HMS is started, but the HK threads are not started? Maybe extend the log line that the HMS is started? - Peter Vary On máj. 8, 2020, 9:46 de, Peter Varga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72480/ > ----------------------------------------------------------- > > (Updated máj. 8, 2020, 9:46 de) > > > Review request for hive, Miklos Gergely and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > Fix the timing to avoid flakyness. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreHousekeepingLeaderTestBase.java > a39a9c8e04 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreTaskThreadAlwaysTestImpl.java > 4cd2c58896 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/RemoteMetastoreTaskThreadTestImpl1.java > c590b6aad5 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/RemoteMetastoreTaskThreadTestImpl2.java > 5b50f66c51 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreHousekeepingLeader.java > 03a8161ea4 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreHousekeepingLeaderEmptyConfig.java > 75ea637503 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetastoreHousekeepingNonLeader.java > 0341d3c03b > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 7bba8d6ee6 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java > 2702e69f86 > > > Diff: https://reviews.apache.org/r/72480/diff/2/ > > > Testing > ------- > > > Thanks, > > Peter Varga > >
