> On May 18, 2020, 2:01 p.m., Zoltan Haindrich wrote: > > parser/src/java/org/apache/hadoop/hive/ql/parse/ParseDriverContext.java > > Lines 23 (patched) > > <https://reviews.apache.org/r/72511/diff/1/?file=2232503#file2232503line23> > > > > I think if the "parse" method would return with an object which has the > > astTree and the tokens; then the setTokenRewrite and the other method can > > be done at the caller level - which would be more straightforward to me.... > > > > what do you think?
It can work, if the order of these method call doesn't matter. - Krisztian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/#review220807 ----------------------------------------------------------- On May 18, 2020, 3:32 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72511/ > ----------------------------------------------------------- > > (Updated May 18, 2020, 3:32 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez and Zoltan Haindrich. > > > Bugs: HIVE-23491 > https://issues.apache.org/jira/browse/HIVE-23491 > > > Repository: hive-git > > > Description > ------- > > Move ParseDriver to parser module > > > Diffs > ----- > > parser/pom.xml 0edae27fa4 > parser/src/java/org/apache/hadoop/hive/ql/parse/ParseResult.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 46f1ec040a > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseException.java > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java e89d154b7a > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > aa8d84ec9c > ql/src/test/org/apache/hadoop/hive/ql/parse/TestIUD.java 4ec111cf1e > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMergeStatement.java > 396d344dd6 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseDriver.java d6250f1c03 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseDriverIntervals.java > fdc4cfa8dd > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseWithinGroupClause.java > fb7699e0e4 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBCompact.java e564525075 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBSubQuery.java 5a0898c5da > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestReplicationSemanticAnalyzer.java > e52216cdcc > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java > fbf2b8bb9a > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestUnpermittedCharsInColumnNameCreateTableNegative.java > 02d46dc3cd > > ql/src/test/org/apache/hadoop/hive/ql/parse/positive/TestTransactionStatement.java > b13aa6855a > > > Diff: https://reviews.apache.org/r/72511/diff/2/ > > > Testing > ------- > > mvn clean install -pl parser > mvn clean install -DskipTests -pl ql > > > Thanks, > > Krisztian Kasa > >
