----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220805 -----------------------------------------------------------
Minor comments only. Thanks for the patch! common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 2635-2636 (original), 2635-2636 (patched) <https://reviews.apache.org/r/72281/#comment309510> nit: spaces at the end of the lines (seems to me usually we do not do that) ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java Lines 305 (patched) <https://reviews.apache.org/r/72281/#comment309509> Migth want to add asserts here to check non-null argument - Peter Vary On márc. 30, 2020, 6:18 de, Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72281/ > ----------------------------------------------------------- > > (Updated márc. 30, 2020, 6:18 de) > > > Review request for hive and Laszlo Pinter. > > > Bugs: HIVE-22971 > https://issues.apache.org/jira/browse/HIVE-22971 > > > Repository: hive-git > > > Description > ------- > > File rename is expensive for object stores, so MM (insert-only) compaction > should skip that step when committing and write directly to base_x_cZ or > delta_x_y_cZ. > > This also fixes the issue that for MM QB compaction the temp tables were > stored under the table directory, and these temp dirs were never cleaned up. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 34df01e60e > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java > 95fa6641f2 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java > 9659a3f048 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 543ec0b991 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java > f47c23a6de > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java > 1bf0beea40 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > 114b6f7a74 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java > 383891bfad > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java > 7f3ccfa04e > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java > 6542eef58a > > > Diff: https://reviews.apache.org/r/72281/diff/1/ > > > Testing > ------- > > > Thanks, > > Karen Coppage > >
