----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72462/#review220771 -----------------------------------------------------------
ql/src/test/queries/clientpositive/msck_repair_4.q Lines 8 (patched) <https://reviews.apache.org/r/72462/#comment309467> Add a testcase with table path repairtable_n4 having upper case. You can achieve it by setting location in create table. standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java Lines 116 (patched) <https://reviews.apache.org/r/72462/#comment309464> Why do we need pathSet? Can we check if path == null instead? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java Line 1441 (original), 1441 (patched) <https://reviews.apache.org/r/72462/#comment309465> Even table name in directory can be any case. Should we use equalsIgnoresCase here? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java Line 1454 (original), 1456 (patched) <https://reviews.apache.org/r/72462/#comment309466> Need to check how Hive treats ptn='A' and ptn='a' as ptn keys are lowercase but values can be any case. - Sankar Hariappan On May 3, 2020, 5:26 a.m., Adesh Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72462/ > ----------------------------------------------------------- > > (Updated May 3, 2020, 5:26 a.m.) > > > Review request for hive and Sankar Hariappan. > > > Repository: hive-git > > > Description > ------- > > The fix converts partition keys to lowercase present in hdfs directory, but > store the hdfs directory as is for partition path. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/msck_repair_4.q PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_4.q.out PRE-CREATION > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java > 5287f47e21 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java > 6f4400a8ef > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java > f4e109d1b0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > 7c4e129738 > > > Diff: https://reviews.apache.org/r/72462/diff/1/ > > > Testing > ------- > > > Thanks, > > Adesh Rao > >
