> On May 5, 2020, 5:04 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 832 (original), 830 (patched) > > <https://reviews.apache.org/r/72437/diff/3/?file=2230109#file2230109line839> > > > > isView only used for this check here, which can be eliminated. > > Attila Magyar wrote: > Not sure what you mean by eliminating it? Removing it altogeather?
yes remove this if(), its only purpose is to throw exception. We can remove this to save RDBMS query for isViewTable() - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72437/#review220616 ----------------------------------------------------------- On April 27, 2020, 9:15 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72437/ > ----------------------------------------------------------- > > (Updated April 27, 2020, 9:15 a.m.) > > > Review request for hive, Ashutosh Chauhan, Rajesh Balamohan, and Vineet Garg. > > > Bugs: HIVE-23282 > https://issues.apache.org/jira/browse/HIVE-23282 > > > Repository: hive-git > > > Description > ------- > > ObjectStore::getPartitionsByExprInternal internally uses Table information > for getting partitionKeys, table, catalog name. > > > > For this, it ends up populating entire table data from DB (including skew > column, parameters, sort, bucket cols etc). This makes it a lot more > expensive call. It would be good to check if MTable itself can be used > instead of Table. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 4f58cd91efc > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > d1558876f14 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 53b7a67a429 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java > 9834883f00f > > > Diff: https://reviews.apache.org/r/72437/diff/4/ > > > Testing > ------- > > > Thanks, > > Attila Magyar > >
