----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72436/#review220540 -----------------------------------------------------------
Ship it! Ship It! - Marton Bod On April 29, 2020, 10:18 a.m., Denys Kuzmenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72436/ > ----------------------------------------------------------- > > (Updated April 29, 2020, 10:18 a.m.) > > > Review request for hive, Marton Bod and Peter Vary. > > > Bugs: HIVE-23293 > https://issues.apache.org/jira/browse/HIVE-23293 > > > Repository: hive-git > > > Description > ------- > > With a new lock type (EXCL_WRITE) for INSERT_OVERWRITE, SHARED_READ does not > have to wait for any lock - it can fails fast for a pending EXCLUSIVE, > because even if there is an EXCL_WRITE or SHARED_WRITE pending, there's no > semantic reason to wait for them. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 8e643fe844 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java fb5a306ac4 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java b4dac4346e > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > f90396b2a3 > ql/src/test/results/clientnegative/insert_into1.q.out 066f04d1cc > ql/src/test/results/clientnegative/insert_into2.q.out b839efeb7d > ql/src/test/results/clientnegative/insert_into3.q.out 91aeb5b9a1 > ql/src/test/results/clientnegative/insert_into4.q.out 303fb6aa2e > ql/src/test/results/clientnegative/lockneg_try_drop_locked_db.q.out > e66965e693 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java > 7402fb30eb > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockResponse.java > fdaab4b394 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 9fb7ff011a > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 4f317b3453 > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > e64ae0ead2 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/LockRequestBuilder.java > 93da0f60ec > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 1e3d6e9b8b > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > fe39b0b36e > > > Diff: https://reviews.apache.org/r/72436/diff/6/ > > > Testing > ------- > > DbTxnManager tests > > > Thanks, > > Denys Kuzmenko > >
