-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72392/
-----------------------------------------------------------
Review request for hive, Denys Kuzmenko and Marton Bod.
Bugs: HIVE-23103
https://issues.apache.org/jira/browse/HIVE-23103
Repository: hive-git
Description
-------
Examine how to really get better performance for oracle statement batches.
Oracle JDBC doc describes:
The Oracle implementation of standard update batching does not implement true
batching for generic statements and callable statements. Even though Oracle
JDBC supports the use of standard batching for Statement and CallableStatement
objects, you are unlikely to see performance improvement.
I would look for connection properties to set, so it is handled anyway, or if
not, then use:
begin
query1;
query2;
query3;
end;
to we will have only a single roundtrip for the db.
Diffs
-----
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java
bb29410e7d
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
d080df417b
Diff: https://reviews.apache.org/r/72392/diff/1/
Testing
-------
Baseline:
Benchmark (dbProduct) (txnType) Mode Cnt Score
Error Units
TxnHandlerBenchRunner.commitTxn ORACLE DEFAULT ss 100 42.988 ±
4.569 ms/op
TxnHandlerBenchRunner.commitTxn ORACLE READ_ONLY ss 100 45.029 ±
4.686 ms/op
After patch:
Benchmark (dbProduct) (txnType) Mode Cnt Score
Error Units
TxnHandlerBenchRunner.commitTxn ORACLE DEFAULT ss 100 36.208 ±
3.869 ms/op
TxnHandlerBenchRunner.commitTxn ORACLE READ_ONLY ss 100 37.038 ±
3.746 ms/op
Thanks,
Peter Vary
