----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72360/#review220331 -----------------------------------------------------------
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Lines 650-651 (patched) <https://reviews.apache.org/r/72360/#comment308657> The text describing the config value is for administrators and not for developers. So this part should be a java comment instead of being part of the description standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 2520-2525 (patched) <https://reviews.apache.org/r/72360/#comment308658> I would do it in setConf, like we did with the numOpenTxns and friends - Peter Vary On ápr. 14, 2020, 2:25 du, Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72360/ > ----------------------------------------------------------- > > (Updated ápr. 14, 2020, 2:25 du) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23093: Create new metastore config value for jdbc max batch size > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 3bfb0e69cb > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > 620c77e589 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 7d0db0c3a0 > > > Diff: https://reviews.apache.org/r/72360/diff/1/ > > > Testing > ------- > > > Thanks, > > Marton Bod > >
