[ 
https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183787#comment-13183787
 ] 

Phabricator commented on HIVE-2655:
-----------------------------------

ikabiljo has commented on the revision "HIVE-2655 [jira] Ability to define 
functions in HQL".

  Looks good, see inline.
  What do I have to do to have power to accept hive diffs? :)

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java:43 why 
stateful? (is that related to serialization?)
  also it should probably be undeterministic since it can expres 
undeterministic function.
  later you can make it check body to see if it is deterministic, and than do 
what is needed in initialize. But no need.

REVISION DETAIL
  https://reviews.facebook.net/D915

                
> Ability to define functions in HQL
> ----------------------------------
>
>                 Key: HIVE-2655
>                 URL: https://issues.apache.org/jira/browse/HIVE-2655
>             Project: Hive
>          Issue Type: New Feature
>          Components: SQL
>            Reporter: Jonathan Perlow
>            Assignee: Jonathan Chang
>         Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch, 
> HIVE-2655.D915.3.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to