> On March 31, 2020, 9:35 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 199 (patched) > > <https://reviews.apache.org/r/72264/diff/2/?file=2216464#file2216464line199> > > > > %d could be problematic with different locales
I will change to be on the safe side > On March 31, 2020, 9:35 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 2412 (patched) > > <https://reviews.apache.org/r/72264/diff/2/?file=2216464#file2216464line2416> > > > > nit: unnecessary move, might make backporting harder sure, makes sense > On March 31, 2020, 9:35 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 2545 (patched) > > <https://reviews.apache.org/r/72264/diff/2/?file=2216464#file2216464line2550> > > > > Is it possible to collect the all of the data before starting the RDBMS > > query, and get all of the data for a enqueueLockRequest in one go? As discussed, good idea, but it would overcomplicate the code and the query structure, whereas usually only 1-2 dbName-tblName combos are locked in one go > On March 31, 2020, 9:35 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 2599 (patched) > > <https://reviews.apache.org/r/72264/diff/2/?file=2216464#file2216464line2652> > > > > Do we need this? We do not commit temp lock id, so we can have just a > > single value which definitely will not appear in the table makes sense, will change to a cheaper placeholder value - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220146 ----------------------------------------------------------- On March 24, 2020, 2:24 p.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72264/ > ----------------------------------------------------------- > > (Updated March 24, 2020, 2:24 p.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23052: Optimize lock enqueueing in TxnHandler > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > f92ce7325e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java > 85719fdf84 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 76bbf3bc1e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72264/diff/2/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21249/ > Custom benchmark results attached to ticket: > https://issues.apache.org/jira/browse/HIVE-23052 > > > Thanks, > > Marton Bod > >
