-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72129/
-----------------------------------------------------------
(Updated Feb. 14, 2020, 1:27 a.m.)
Review request for hive, Gopal V, Peter Vary, and Zoltan Chovan.
Changes
-------
- Removed refactoring changes to simplify changes in this patch.
- Building filter conditions in buildJumpTable(). SQL filters are built off
these.
Repository: hive-git
Description
-------
- Main change is in TxnHandler::checkLock.
- When all incoming requests are SHARED_READ, we can add a condition in the
query to retrieve only relevant rows. This avoids significant number of rows
fetched in the form of "SHARED_READ + ACQUIRED". There is a corner condition of
"SHARED_WRITE --> SHARED_READ::ACQUIRED", which is misleading in the
jumpttable. This condition can be optimised later.
- Also, removed the "HL_PARTITION IN" clause which could potentially
overflow for oracle. Partition details can be filtered out, if the earlier
query actually returned any rows.
- Rest of the changes, are related to refactoring
"TxnHandler::enqueueLockWithRetry" to reduce lock scope.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java a8b9653411
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
f53aebe4ad
Diff: https://reviews.apache.org/r/72129/diff/3/
Changes: https://reviews.apache.org/r/72129/diff/2-3/
Testing
-------
File Attachments
----------------
HIVE-22850.5.patch
https://reviews.apache.org/media/uploaded/files/2020/02/13/74ec6cbd-c552-4d46-b5a6-e2fa6da41bdc__HIVE-22850.5.patch
Thanks,
Rajesh Balamohan
