----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72063/#review219519 -----------------------------------------------------------
ql/src/test/queries/clientpositive/dynpart_cast.q Lines 2 (patched) <https://reviews.apache.org/r/72063/#comment307717> Thanks for addressing the comments. Just another minor comment. Can we add this test under 'minillap.query.files'? Right now this is MR test but since we use Tez/Llap it will be better under that. You'll need to run "TestTezMiniLlapCliDriver' to genrate q file - Vineet Garg On Feb. 6, 2020, 2:22 p.m., Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72063/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2020, 2:22 p.m.) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-10362 > https://issues.apache.org/jira/browse/HIVE-10362 > > > Repository: hive-git > > > Description > ------- > > Example: > create table dynparttypechecknum (key int, value string) partitioned by (part > int); > insert into dynparttypechecknum partition (part) select key, value, '00001' > from src limit 1; > show partitions dynparttypechecknum; > > Partition created will be named: > part=00001 > even though the type of `part` is int. > > Solution is to cast the inserted DP columns in the SelectOperator before > FileSinkOperator which creates the partition dir, not after. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 12a022c590 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > c2514eedb1 > ql/src/test/queries/clientpositive/dynpart_cast.q PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_6.q.out da3be3e5bb > ql/src/test/results/clientpositive/dynpart_cast.q.out PRE-CREATION > ql/src/test/results/clientpositive/dynpart_sort_optimization_acid2.q.out > 43bb789840 > ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out > f745b46899 > ql/src/test/results/clientpositive/llap/dynpart_sort_opt_bucketing.q.out > 453d2451df > ql/src/test/results/clientpositive/llap/orc_merge1.q.out 9da73e65ac > ql/src/test/results/clientpositive/llap/orc_merge10.q.out a6ea33493f > ql/src/test/results/clientpositive/llap/orc_merge2.q.out 9b0d3b4234 > ql/src/test/results/clientpositive/llap/orc_merge_diff_fs.q.out d35f44b10a > ql/src/test/results/clientpositive/llap/rcfile_merge2.q.out fcff20a68e > ql/src/test/results/clientpositive/llap/tez_dml.q.out 4ad78d8582 > ql/src/test/results/clientpositive/orc_merge1.q.out 9c07816340 > ql/src/test/results/clientpositive/orc_merge10.q.out 4a5f03c82f > ql/src/test/results/clientpositive/orc_merge2.q.out d132d62b18 > ql/src/test/results/clientpositive/orc_merge_diff_fs.q.out 7f9a04b09f > ql/src/test/results/clientpositive/smb_join_partition_key.q.out c18d01d26a > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out > 56d5ed945b > ql/src/test/results/clientpositive/spark/orc_merge1.q.out 977c4cbfc1 > ql/src/test/results/clientpositive/spark/orc_merge2.q.out 4647b86ea3 > ql/src/test/results/clientpositive/spark/orc_merge_diff_fs.q.out b7d3dd725d > > > Diff: https://reviews.apache.org/r/72063/diff/3/ > > > Testing > ------- > > > Thanks, > > Karen Coppage > >
