----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72088/ -----------------------------------------------------------
(Updated Feb. 6, 2020, 9:17 a.m.) Review request for hive and Zoltan Haindrich. Bugs: HIVE-22835 https://issues.apache.org/jira/browse/HIVE-22835 Repository: hive-git Description ------- The Driver class contains ~600 lines of code responsible for executing the command. That means that from the Query Plan as input the appropriate tasks should be executed. This is a thing done by the execute function, which is ~300 lines long, and also has some sub functions to help this task. All these codes should be put into a separate class, where it can do it's job without getting mixed with the other codes in the Driver. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/Driver.java 342d463480 ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java bbf7fe5379 ql/src/java/org/apache/hadoop/hive/ql/Executor.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/IDriver.java baad2694b3 ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecDriver.java eab7f45fde Diff: https://reviews.apache.org/r/72088/diff/2/ Changes: https://reviews.apache.org/r/72088/diff/1-2/ Testing ------- The tests are still running. Thanks, Miklos Gergely