[ https://issues.apache.org/jira/browse/HIVE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181220#comment-13181220 ]
Phabricator commented on HIVE-2629: ----------------------------------- amareshwarisr has commented on the revision "HIVE-2629 [jira] Make a single Hive binary work with both 0.20.x and 0.23.0". I realize that it is not possible to keep all the files in common itself. The suggestion is to rename commonSecure to common-secure, as the former name does not fit into the directory name style. Also, I could not run 'ant package' after applying the patch, as it was failing with Out of memory issues. INLINE COMMENTS shims/build.xml:62 Earlier shim builds exclude Proxy*.java files and include them separately in compile. Not sure why it is done so. But this patch removes the functionality. When I dig through svn history, it is done by HIVE-1408 to make hive automatically run in local mode. Not sure if it is still required. anyone aware this? REVISION DETAIL https://reviews.facebook.net/D711 > Make a single Hive binary work with both 0.20.x and 0.23.0 > ---------------------------------------------------------- > > Key: HIVE-2629 > URL: https://issues.apache.org/jira/browse/HIVE-2629 > Project: Hive > Issue Type: Bug > Components: Shims > Reporter: Carl Steinbach > Assignee: Thomas Weise > Fix For: 0.9.0 > > Attachments: HIVE-2629.D711.1.patch, HIVE-2629.D711.2.patch, > HIVE-2629.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira