----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71801/ -----------------------------------------------------------
Review request for hive, Laszlo Bodor, Panos Garefalakis, and Slim Bouguerra. Bugs: HIVE-22523 https://issues.apache.org/jira/browse/HIVE-22523 Repository: hive-git Description ------- In setError() we set the value of an atomic reference (pendingError) and we also put the error in a queue. The latter seems not just unnecessary but it might block the caller of the handler if the queue is full. Also closing the reader might not properly handled as some of the flags are not volatile. Diffs ----- llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java 77966aa9650 Diff: https://reviews.apache.org/r/71801/diff/1/ Testing ------- q tests Thanks, Attila Magyar