[
https://issues.apache.org/jira/browse/HIVE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179233#comment-13179233
]
Phabricator commented on HIVE-2203:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2203 [jira] Extend
concat_ws() UDF to support arrays of strings".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:36
I think this should be changed to:
CONCAT_WS(sep, [string | array(string)]+)
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:69
Please add a negative testcase that exercises this validation code. Other
examples of this are available here: ql/src/test/queries/clientnegative/udf_*.q
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:62
Can you rewrite this using switch statements? I generally find that easier to
read.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:99
Indentation is wrong here. Please use 2 character indents.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java:103
Leave a space after semicolons in a for statement.
ql/src/test/queries/clientpositive/udf_concat_ws.q:20 Please add an EXPLAIN
query.
ql/src/test/queries/clientpositive/udf_concat_ws.q:28 Maybe replace this
query with one call to concat_ws(NULL, ....) in the previous query?
REVISION DETAIL
https://reviews.facebook.net/D1071
> Extend concat_ws() UDF to support arrays of strings
> ---------------------------------------------------
>
> Key: HIVE-2203
> URL: https://issues.apache.org/jira/browse/HIVE-2203
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Priority: Minor
> Attachments: HIVE-2203.D1065.1.patch, HIVE-2203.D1071.1.patch
>
>
> concat_ws() should support the following type of input parameters:
> concat_ws(string separator, array<string>)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
