----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71458/#review217662 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java Lines 272 (patched) <https://reviews.apache.org/r/71458/#comment304957> I think _needColStats_ is only true when we call this method from CBO? What happens with CBO if estimate stats is set to false and stats for any column are not present, i.e., does it fail completely or only the stage that is dependent on the stats (for instance, join reordering)? I think the desired behavior is the latest. We can probably confirm that by checking the logs for join_reordering_no_stats.q test. - Jesús Camacho Rodríguez On Sept. 9, 2019, 5:29 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71458/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2019, 5:29 p.m.) > > > Review request for hive, Gopal V, Jesús Camacho Rodríguez, Zoltan Haindrich, > and Vineet Garg. > > > Bugs: HIVE-22163 > https://issues.apache.org/jira/browse/HIVE-22163 > > > Repository: hive-git > > > Description > ------- > > CBO: Enabling CBO turns on stats estimation, even when the estimation is > disabled > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 1795ae5626 > ql/src/test/queries/clientpositive/cbo_stats_estimation.q PRE-CREATION > ql/src/test/results/clientpositive/cbo_stats_estimation.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/join_reordering_no_stats.q.out > fddffbb0a8 > > > Diff: https://reviews.apache.org/r/71458/diff/1/ > > > Testing > ------- > > New qtest: cbo_stats_estimation.q > > > Thanks, > > Krisztian Kasa > >
