> On Aug. 14, 2019, 10:40 p.m., Thejas Nair wrote: > > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > > Lines 1938 (patched) > > <https://reviews.apache.org/r/71267/diff/1-2/?file=2160426#file2160426line1938> > > > > To future proof that, it would have better better to have a > > GetDatabaseResponse as well > > similar to get_catalog. > > That can be a smaller follo wup patch
will create a separate jira for this. - Naveen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71267/#review217212 ----------------------------------------------------------- On Aug. 14, 2019, 6:26 a.m., Naveen Gangam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71267/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2019, 6:26 a.m.) > > > Review request for hive, Daniel Dai, Jason Dere, and Thejas Nair. > > > Bugs: HIVE-22087 > https://issues.apache.org/jira/browse/HIVE-22087 > > > Repository: hive-git > > > Description > ------- > > 1) getDatabase() calls should be transformed to return a Database object that > can vary in location depending on the client capabilities. If client has > ACID*WRITE* capabilities, location is unaltered. If the client does not have > such capabilities, the database will return an location from the external > warehouse directory. > 2) When a non-ACID MANAGED table is translated to EXTERNAL table, its > location should be altered to point to an external warehouse directory and > not to the managed warehouse. > 3) Some new test cases. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreTransformer.java > e50b577ff7 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlterPartitionsRequest.java > 6453c93d79 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreateTableRequest.java > 5d42a80373 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FindSchemasByColsResp.java > 4024751ed3 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetDatabaseRequest.java > PRE-CREATION > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java > fcba6ebb4d > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectionSpec.java > d94cbb1bcc > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java > dd4bf8339a > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java > ddfa59fb1c > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RenamePartitionRequest.java > de467c298f > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SchemaVersion.java > 09fcd476e9 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > 6b117291a6 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java > 080111d85b > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java > d0174005ca > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java > e5425909d4 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java > b12c2284a2 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php > 4623e9ab5f > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 0d45371b88 > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > 647c762acd > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 5107d0f99a > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 08c0730e1c > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > 8ce2b88fd8 > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb > 7a6a722d9a > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 9b64028a76 > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > e9a15a5d82 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > b3e6e1da76 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreMetadataTransformer.java > c460e12826 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java > 1d98b09ed7 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > 3d66c3f027 > > > Diff: https://reviews.apache.org/r/71267/diff/2/ > > > Testing > ------- > > Unit tests > Some testing done by the Spark team. > > > Thanks, > > Naveen Gangam > >
