----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70190/#review214003 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java Line 816 (original), 836 (patched) <https://reviews.apache.org/r/70190/#comment300169> Adding enum interperation for CHAR and going through same path of makeHiveUnicodeString for CHAR will make the code more redabled and clear. ExprNodeDesc visitLiteral(RexLiteral literal) will need to be udpated accordingly. ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java Lines 1442 (patched) <https://reviews.apache.org/r/70190/#comment300170> Add a comment explaining why ql/src/test/results/clientpositive/in_typecheck_varchar.q.out Line 125 (original) <https://reviews.apache.org/r/70190/#comment300171> Strange that this is not being vectorized anymore. - Vineet Garg On March 12, 2019, 11:55 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70190/ > ----------------------------------------------------------- > > (Updated March 12, 2019, 11:55 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-21316 > https://issues.apache.org/jira/browse/HIVE-21316 > > > Repository: hive-git > > > Description > ------- > > preserver varchar type during/after constant folding > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties > a237745487785bc259ee10ee0989f215ee854572 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java > 6dd00189d60e5c01495a5ebd8b64ac339ea59525 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java > d15c710c5e12ec7c6af0256afab3ba1dd4d6a92e > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > a2dd554b6ea00a3769d2d1593e36835433a96d57 > ql/src/test/queries/clientpositive/fold_varchar.q PRE-CREATION > ql/src/test/results/clientpositive/in_typecheck_varchar.q.out > f51ff29dbac90b8d35ab8cb4007bf17efbf34543 > ql/src/test/results/clientpositive/llap/fold_varchar.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_6.q.out > ee5dfd1e1cfc1b2204f7260626f6c43f1ab2ba88 > > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_no_join_opt.q.out > b022ee8ff57c34cc4244bb790e6971a8127fd1b8 > ql/src/test/results/clientpositive/llap/vector_case_when_1.q.out > 6529758a3a9977154276ba6d8b2dafce922c4d64 > ql/src/test/results/clientpositive/vector_case_when_1.q.out > 61062e1f8e08306061034c1923d0178a428c6475 > > > Diff: https://reviews.apache.org/r/70190/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
