sankarh commented on a change in pull request #578: HIVE-21471: Replicating
conversion of managed to external table leaks HDFS files at target.
URL: https://github.com/apache/hive/pull/578#discussion_r268381343
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
##########
@@ -357,6 +368,13 @@ public void alterTable(RawStore msdb, Warehouse wh,
String catName, String dbnam
}
}
+ // If data location is changed in replication flow, then need to delete
the old path.
+ if (replDataLocationChanged) {
+ Path deleteOldDataLoc = new Path(oldt.getSd().getLocation());
+ boolean isAutoPurge =
"true".equalsIgnoreCase(oldt.getParameters().get("auto.purge"));
+ wh.deleteDir(deleteOldDataLoc, true, isAutoPurge, olddb);
Review comment:
Good catch. Will move it to finally block only when success=true and eat any
exception by DeleteDir and just log a warn instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
