----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70256/#review213878 -----------------------------------------------------------
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java Lines 3153-3155 (patched) <https://reviews.apache.org/r/70256/#comment299990> My concern here is that we testing a different case with the patch. Before we tested that we open/use/close a client and do not have lingering object. After the patch we test that closing the client will remove the 1 object - which says that the getAllDatabases will result in exactly 1 object. How could that happen that there are lingering objects when we create a new client? Is there a way to get rid of the lingering object somehow, and then test the original usecase? - Peter Vary On márc. 20, 2019, 6:43 du, Morio Ramdenbourg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70256/ > ----------------------------------------------------------- > > (Updated márc. 20, 2019, 6:43 du) > > > Review request for hive, Adam Holley, Karthik Manamcheri, Karen Coppage, > Peter Vary, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > This test was not correctly counting the number of > objects in the PersistenceManager cache before and after > HiveMetaStoreClient.close(). The > getJDOPersistenceManagerCacheSize() internal helper method did not use > the updated fields present in the metastore classes, and was > consistently returning -1. Additionally, there was a chance to cause > flakiness since the object count before and after close() could > differ depending on lingering objects from previous > tests or setup. > > Modified the helper method to use the new > fields, and fixed the flakiness on this test. > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 77e0c98265e7b561f2eb39536e3251dd92e9cab0 > > > Diff: https://reviews.apache.org/r/70256/diff/1/ > > > Testing > ------- > > Unit tests run > > > Thanks, > > Morio Ramdenbourg > >
