animenon commented on a change in pull request #388: HIVE-20057: Fix Hive table
conversion DESCRIBE table bug
URL: https://github.com/apache/hive/pull/388#discussion_r264023088
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1802,12 +1802,12 @@ private MTable convertToMTable(Table tbl) throws
InvalidObjectException,
// accordingly
String tableType = tbl.getTableType();
boolean isExternal =
Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
- if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
+ if (TableType.MANAGED_TABLE.toString().equalsIgnoreCase(tableType)) {
Review comment:
IgnoreCase used
[here](https://github.com/apache/hive/blob/e4d60e29910ec709d432fd85819cb6b6d097d689/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1810)
:
`if (TableType.EXTERNAL_TABLE.toString().equalsIgnoreCase(tableType))`
for EXTERNAL property and tableType equals check would check if equals
ignoring the case of letters.
I agree the tableType ignoreCase
[here](https://github.com/apache/hive/blob/e4d60e29910ec709d432fd85819cb6b6d097d689/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L1805)
may not be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
