Peter Vary created HIVE-21402:
---------------------------------

             Summary: Compaction state remains 'working' when major compaction 
fails
                 Key: HIVE-21402
                 URL: https://issues.apache.org/jira/browse/HIVE-21402
             Project: Hive
          Issue Type: Bug
          Components: Transactions
    Affects Versions: 4.0.0
            Reporter: Peter Vary


When calcite is not on the HMS classpath, and query based compaction is enabled 
then the compaction fails with NoClassDefFound error. Since the catch block 
only catches Exceptions the following code block is not executed:
{code:java}
} catch (Exception e) {
  LOG.error("Caught exception while trying to compact " + ci +
      ".  Marking failed to avoid repeated failures, " + 
StringUtils.stringifyException(e));
  msc.markFailed(CompactionInfo.compactionInfoToStruct(ci));
  msc.abortTxns(Collections.singletonList(compactorTxnId));
}
{code}
So the compaction is not set to failed.

Would be better to catch Throwable instead of Exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to