jcamachor commented on a change in pull request #557: HIVE-21338 Remove order
by and limit for aggregates
URL: https://github.com/apache/hive/pull/557#discussion_r262715669
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -1925,6 +1926,11 @@ public RelNode apply(RelOptCluster cluster,
RelOptSchema relOptSchema, SchemaPlu
perfLogger.PerfLogEnd(this.getClass().getName(), PerfLogger.OPTIMIZER,
"Calcite: Window fixing rule");
}
+ perfLogger.PerfLogBegin(this.getClass().getName(), PerfLogger.OPTIMIZER);
Review comment:
I believe we may still compute aggregations that are not used in the plan
output. Could include the following test to confirm:
```
explain cbo
SELECT COUNT(*) FROM t1 ORDER BY SUM(col), COUNT(*);
```
I believe this is not critical, but we can add the test and a note to the q
file, and create a placeholder JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
