massdosage commented on a change in pull request #555: [HIVE-21345][CLI] Fix the error when hive cliDriver parses sql statement h semicolon in a pair of double quote URL: https://github.com/apache/hive/pull/555#discussion_r261163681
########## File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java ########## @@ -445,6 +445,17 @@ public void handle(Signal signal) { } break; case '"': + if (!escape) { Review comment: I'm pretty sure the Hive maintainers will want unit tests that cover all of these cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services