maheshk114 commented on a change in pull request #541: HIVE-21197 : Hive
Replication can add duplicate data during migration to a target with
hive.strict.managed.tables enabled
URL: https://github.com/apache/hive/pull/541#discussion_r260134323
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
##########
@@ -5216,7 +5216,8 @@ private int updateFirstIncPendingFlag(Hive hive,
ReplSetFirstIncLoadFlagDesc des
for (String tableName : Utils.matchesTbl(hive, dbNameOrPattern,
tableNameOrPattern)) {
org.apache.hadoop.hive.metastore.api.Table tbl =
hive.getMSC().getTable(dbNameOrPattern, tableName);
parameters = tbl.getParameters();
- if (ReplUtils.isFirstIncPending(parameters)) {
+ String incPendPara = parameters != null ?
parameters.get(ReplUtils.REPL_FIRST_INC_PENDING_FLAG) : null;
+ if (incPendPara != null && (!flag.equalsIgnoreCase(incPendPara))) {
Review comment:
no ..as per current code ..we change this value only we are going to change
it to other one ..else no need to change ..as this is called only after
incremental is done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
