miklosgergely commented on a change in pull request #544: HIVE-16924 Support 
distinct in presence of Group By
URL: https://github.com/apache/hive/pull/544#discussion_r259837145
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
 ##########
 @@ -4230,6 +4229,34 @@ public static long unsetBit(long bitmap, int bitIdx) {
     }
   }
 
+  protected boolean isGroupBy(ASTNode expr) {
 
 Review comment:
   renamed to hasGroupBySibling(ASTNode selectExpr)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to