sankarh commented on a change in pull request #541: HIVE-21197 : Hive
Replication can add duplicate data during migration to a target with
hive.strict.managed.tables enabled
URL: https://github.com/apache/hive/pull/541#discussion_r259751152
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java
##########
@@ -426,4 +427,14 @@ public static void copyLastReplId(Map<String, String>
srcParameter, Map<String,
destParameter.put(ReplicationSpec.KEY.CURR_STATE_ID.toString(),
lastReplId);
}
}
+
+ public boolean needDupCopyCheck() {
+ return needDupCopyCheck;
+ }
+
+ public void setNeedDupCopyCheck(boolean isFirstIncPending) {
Review comment:
We can abstract the caller logic that duplicate copy check needed if first
incremental pending.
Shall change the name of isFirstIncPending to isNeedDupCopyCheck.
Also, the comment can be moved to caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
