maheshk114 commented on a change in pull request #541: HIVE-21197 : Hive
Replication can add duplicate data during migration to a target with
hive.strict.managed.tables enabled
URL: https://github.com/apache/hive/pull/541#discussion_r259606409
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
##########
@@ -187,4 +192,12 @@ public static PathFilter getEventsDirectoryFilter(final
FileSystem fs) {
}
};
}
+
+ public static boolean isFirstIncDone(Map<String, String> parameter) {
+ if (parameter == null) {
+ return true;
+ }
+ String compFlag = parameter.get(ReplUtils.REPL_FIRST_INC_PENDING_FLAG);
+ return compFlag == null || compFlag.isEmpty() ||
"false".equalsIgnoreCase(compFlag);
Review comment:
i think better to have this check as for this case null and empty has
special meaning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
