sankarh commented on a change in pull request #541: HIVE-21197 : Hive 
Replication can add duplicate data during migration to a target with 
hive.strict.managed.tables enabled
URL: https://github.com/apache/hive/pull/541#discussion_r259237893
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
 ##########
 @@ -112,6 +118,12 @@ public void run() {
                 continue;
               }
 
+              if (replIsCompactionDisabledForTable(t)) {
 
 Review comment:
   I think, we can disable compaction in DB level only. Even table level 
replication replicates it DB level with list of tables. It will be simple and 
easy to maintain.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to