> On Jan. 24, 2019, 7:53 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/69830/diff/1/?file=2121964#file2121964line47> > > > > Instead of using the shaded version, we should use our own guava > > version directly.
I was sure that it will be available...but it seems like these graph classes are added in Guava 20.0; but Hive uses 19 In the latest patch I'm considering to upgrade to Guava 23 - because thats what HBase uses I've seen HIVE-15393; so not sure if that would be a viable option or not - and that should be probably done in a separate ticket as it might involve hadoop or other libraries I ended up "rolling some simple graph class" to make this work... > On Jan. 24, 2019, 7:53 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/test/results/clientpositive/join34.q.out > > Line 35 (original) > > <https://reviews.apache.org/r/69830/diff/1/?file=2121972#file2121972line35> > > > > We lost the optimized SQL, maybe because we do not support unparsing of > > BETWEEN clause? We can tackle in follow-up, but it would be good to know > > the root cause. yes, opened HIVE-21187 > On Jan. 24, 2019, 7:53 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/test/results/clientpositive/vector_between_columns.q.out > > Line 160 (original), 160 (patched) > > <https://reviews.apache.org/r/69830/diff/1/?file=2122031#file2122031line160> > > > > Nothing changed below in the plan, but BETWEEN expression columns have > > changed here. Is this correct? yes this is correct: ``` _col4 <= _col1 and _col1 <= _col4 (_col4 in _col1 and _col1) # change the order of the operands _col1 <= _col4 and _col4 <= _col1 (_col1 in _col4 and _col4) ``` the best simplification would be to notice that in this case `_col1 = _col4`; we miss that in `RexSimplify` I've seen a ticket from Gopal: https://issues.apache.org/jira/browse/HIVE-18167 and probably not closing BETWEEN in case the range has column references might be a way to address that - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69830/#review212278 ----------------------------------------------------------- On Jan. 24, 2019, 3:31 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69830/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 3:31 p.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and > Vineet Garg. > > > Bugs: HIVE-21143 > https://issues.apache.org/jira/browse/HIVE-21143 > > > Repository: hive-git > > > Description > ------- > > patch #1 here is #7 on jira > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java > 9a525adeb9 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java > a920e4096e > ql/src/test/queries/clientpositive/udf_between.q 9ee33520b9 > ql/src/test/results/clientpositive/correlationoptimizer8.q.out 9ad55cd91f > ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd > ql/src/test/results/clientpositive/druid_timeseries.q.out fd69771e61 > ql/src/test/results/clientpositive/filter_numeric.q.out 74ce762191 > ql/src/test/results/clientpositive/infer_join_preds.q.out d73005c82d > ql/src/test/results/clientpositive/join34.q.out f5a280f186 > ql/src/test/results/clientpositive/join35.q.out 227782126c > ql/src/test/results/clientpositive/join45.q.out 8a6fd8fcec > ql/src/test/results/clientpositive/join47.q.out 475079dacf > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb.q.out > d98a9b665d > > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb_2.q.out > abefa7eaa2 > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 2a684018df > ql/src/test/results/clientpositive/llap/vector_between_columns.q.out > a91a36b358 > ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 3b2b7ba971 > ql/src/test/results/clientpositive/mapjoin47.q.out 67b2f4cd03 > ql/src/test/results/clientpositive/partition_wise_fileformat2.q.out > a1c5ab3071 > ql/src/test/results/clientpositive/pcr.q.out 660556ffe9 > ql/src/test/results/clientpositive/perf/spark/query13.q.out 2b6c19d6c2 > ql/src/test/results/clientpositive/perf/spark/query21.q.out 6c2efe75c9 > ql/src/test/results/clientpositive/perf/spark/query34.q.out 1dd58b399f > ql/src/test/results/clientpositive/perf/spark/query48.q.out 024d205290 > ql/src/test/results/clientpositive/perf/spark/query54.q.out 690f1d4cdf > ql/src/test/results/clientpositive/perf/spark/query58.q.out d3c7e0b84c > ql/src/test/results/clientpositive/perf/spark/query85.q.out a7bf288044 > ql/src/test/results/clientpositive/perf/tez/cbo_query13.q.out 19f3039781 > ql/src/test/results/clientpositive/perf/tez/cbo_query21.q.out 3a675034ef > ql/src/test/results/clientpositive/perf/tez/cbo_query34.q.out 9299409a89 > ql/src/test/results/clientpositive/perf/tez/cbo_query48.q.out 079556ec99 > ql/src/test/results/clientpositive/perf/tez/cbo_query54.q.out 50fa078159 > ql/src/test/results/clientpositive/perf/tez/cbo_query58.q.out b4410ff07a > ql/src/test/results/clientpositive/perf/tez/cbo_query64.q.out 5a5bb797a1 > ql/src/test/results/clientpositive/perf/tez/cbo_query85.q.out f5a71b422b > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query13.q.out > 811a5184aa > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query21.q.out > f304762b14 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query34.q.out > 6e7384e1dd > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query48.q.out > 12d59348f7 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query54.q.out > 6af3162b28 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query58.q.out > 3e89c2da75 > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query64.q.out > 4261d0655d > ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query85.q.out > 6471345141 > ql/src/test/results/clientpositive/perf/tez/constraints/query13.q.out > ac81e3794c > ql/src/test/results/clientpositive/perf/tez/constraints/query21.q.out > 67fdc85be3 > ql/src/test/results/clientpositive/perf/tez/constraints/query34.q.out > 5b0ded736f > ql/src/test/results/clientpositive/perf/tez/constraints/query48.q.out > af9d44207d > ql/src/test/results/clientpositive/perf/tez/constraints/query54.q.out > 8d10899c63 > ql/src/test/results/clientpositive/perf/tez/constraints/query58.q.out > daeda3fdc6 > ql/src/test/results/clientpositive/perf/tez/constraints/query64.q.out > 3aee07ad68 > ql/src/test/results/clientpositive/perf/tez/constraints/query85.q.out > 2aa27db1ef > ql/src/test/results/clientpositive/perf/tez/query13.q.out 2cf833bbf1 > ql/src/test/results/clientpositive/perf/tez/query21.q.out 382775a8cc > ql/src/test/results/clientpositive/perf/tez/query34.q.out 4640899c73 > ql/src/test/results/clientpositive/perf/tez/query48.q.out 885be1371f > ql/src/test/results/clientpositive/perf/tez/query54.q.out a029634671 > ql/src/test/results/clientpositive/perf/tez/query58.q.out bff619a052 > ql/src/test/results/clientpositive/perf/tez/query64.q.out 0010c469c7 > ql/src/test/results/clientpositive/perf/tez/query85.q.out 1ada3945fd > ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 008b761e9f > ql/src/test/results/clientpositive/select_unquote_or.q.out 4b9ee0cf1c > ql/src/test/results/clientpositive/smb_mapjoin_47.q.out 57a543cda2 > ql/src/test/results/clientpositive/spark/join34.q.out 7ec6094304 > ql/src/test/results/clientpositive/spark/join35.q.out 8794053873 > ql/src/test/results/clientpositive/spark/pcr.q.out 270f55ad9b > ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d7d652f34c > ql/src/test/results/clientpositive/udf_between.q.out 9ba685adcb > ql/src/test/results/clientpositive/vector_between_columns.q.out 433650503e > > > Diff: https://reviews.apache.org/r/69830/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
