-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3073/
-----------------------------------------------------------
(Updated 2011-12-20 07:22:34.645716)
Review request for hive, John Sichi and Carl Steinbach.
Summary
-------
Is there any reason should not to implement comparing float/double?
This addresses bug HIVE-2586.
https://issues.apache.org/jira/browse/HIVE-2586
Diffs (updated)
-----
data/files/employee.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 888bf47
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 59e55ae
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
3fb3879
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java
dc4670e
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java
f44f353
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java
7d74e82
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java
47fceb1
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java
12369a8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java
22b3bef
ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 498a293
ql/src/test/queries/clientpositive/compare_float_double.q PRE-CREATION
ql/src/test/results/clientpositive/compare_float_double.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/3073/diff
Testing
-------
added test : compare_float_double.q
Thanks,
Navis
