----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/#review211677 -----------------------------------------------------------
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift Lines 383 (patched) <https://reviews.apache.org/r/69664/#comment297132> nit: add comment saying that the unti of this is "seconds since epoch" standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 785 (patched) <https://reviews.apache.org/r/69664/#comment297133> Why not just store it in milliseconds? - Karthik Manamcheri On Jan. 3, 2019, 11:44 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69664/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2019, 11:44 p.m.) > > > Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary. > > > Bugs: HIVE-21077 > https://issues.apache.org/jira/browse/HIVE-21077 > > > Repository: hive-git > > > Description > ------- > > HIVE-21077 : Database should have creation time > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java > 994797698a379e0b08604d73d2d6728a2fcee4df > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 2953a8f327eabdee42dbc66e0c65f89d17add59a > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > f8b862862de4dde8dce3d0dc5f70eafb67b02d2c > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076 > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 7d09a5c296a8ae924d61b200b4cb9135440fd9a0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a9398ae1e79404a15894aa42f451df5d18ed3e4c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 58dc6eefcb840d4dd70af7a47811fab1b5e696d9 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > d43c0c1e70cffbebd39b05f89ec396227c58ac77 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java > f3d2182a04ab81417a55554ba58d9340721513e8 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java > 815b39c483b2233660310983d58194fb1ab2d107 > standalone-metastore/metastore-server/src/main/resources/package.jdo > caaec457194332a99d5cd57bef746e969dd38161 > > standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql > a3c4196dbff7e53be5317631b314983d16a99020 > > standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql > bcaebd18accf86846ae44a6498046514575fc069 > > standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql > 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827 > > standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql > edde08db9ef7ee01800c7cc3a04c813014abdd18 > > standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql > 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b > > standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql > 701acb00984c61f7511dcc48053890b154575d1f > > standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql > b1980c5b83f16614845063516495188ebdd8c2a3 > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > b9f63313251ab1fa6278b862ed9e07e62b234c04 > > standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql > 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2 > > standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql > 0c36069d071d4b60cc338ba729da5d22e08ca8ca > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > d323ac6c90ed20f092b4e179fdb1bed8602ecf63 > > > Diff: https://reviews.apache.org/r/69664/diff/1/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
