[
https://issues.apache.org/jira/browse/HIVE-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172856#comment-13172856
]
jirapos...@reviews.apache.org commented on HIVE-2586:
-----------------------------------------------------
bq. On 2011-12-19 21:21:20, Carl Steinbach wrote:
bq. > ql/src/test/queries/clientpositive/compare_float_double.q, line 1
bq. > <https://reviews.apache.org/r/3073/diff/2/?file=63280#file63280line1>
bq. >
bq. > Please move these tests to ops_comparison.q. I don't think there's
much benefit to adding a new data file with float data, and loading data into
the table adds a lot of time to the test.
bq. >
bq. > Also, this only provides coverage for the changes in
GenericUDFOPEqual. Please add coverage for the other operators that you
modified.
I thought for meaningful test column should be compared to constant/column
instead of comparing constant to constant and I couldn't find any existing
table contains float/double column. All agree on you except that.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3073/#review3982
-----------------------------------------------------------
On 2011-12-08 09:33:37, Navis Ryu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3073/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 09:33:37)
bq.
bq.
bq. Review request for hive, John Sichi and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Is there any reason should not to implement comparing float/double?
bq.
bq.
bq. This addresses bug HIVE-2586.
bq. https://issues.apache.org/jira/browse/HIVE-2586
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. data/files/floatdouble.txt PRE-CREATION
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
59e55ae
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
3fb3879
bq. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java
dc4670e
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java
f44f353
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java
7d74e82
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java
47fceb1
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java
12369a8
bq.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java
22b3bef
bq. ql/src/test/queries/clientpositive/compare_float_double.q PRE-CREATION
bq. ql/src/test/results/clientpositive/compare_float_double.q.out
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3073/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. added test : compare_float_double.q
bq.
bq.
bq. Thanks,
bq.
bq. Navis
bq.
bq.
> Float comparison doesn't work
> -----------------------------
>
> Key: HIVE-2586
> URL: https://issues.apache.org/jira/browse/HIVE-2586
> Project: Hive
> Issue Type: Bug
> Reporter: Robert Surówka
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2586.1.patch.txt
>
>
> Create table with float column, insert to it e.g. 1410.1, and then do select
> * from <that table> where <that column> = 1410.1 . Nothing will be found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
