> On Dec. 6, 2018, 12:06 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java > > Lines 1335 (patched) > > <https://reviews.apache.org/r/69515/diff/1/?file=2112275#file2112275line1335> > > > > We may bail out here if op is an instance of ReduceSinkOperator, since > > this will be a new vertex and thus we will not replicate it. > > > > This may help us having less changes in perf driver.
The reason to not do that is because I noticed that there could be another RS before semi-join RS. To get to semi-join RS we have to keep traversing. > On Dec. 6, 2018, 12:06 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java > > Lines 1337 (patched) > > <https://reviews.apache.org/r/69515/diff/1/?file=2112275#file2112275line1337> > > > > What happens if there is a union with three children: first one is the > > normal operator plan, second and third are semijoin branches? I believe > > this logic would leave the third branch in the plan? Probably we do not > > need the quick bail out. I am addressing this is latest patch - Vineet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69515/#review211066 ----------------------------------------------------------- On Dec. 7, 2018, 12:11 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69515/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2018, 12:11 a.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Bugs: HIVE-21007 > https://issues.apache.org/jira/browse/HIVE-21007 > > > Repository: hive-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 02cebdc5ac > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out > cb3740d09a > ql/src/test/results/clientpositive/perf/tez/cbo_query54.q.out fd5f6d7521 > ql/src/test/results/clientpositive/perf/tez/constraints/query54.q.out > 7a0750eda3 > ql/src/test/results/clientpositive/perf/tez/constraints/query8.q.out > d97f9df397 > ql/src/test/results/clientpositive/perf/tez/query54.q.out a706e9459e > ql/src/test/results/clientpositive/perf/tez/query8.q.out 9eb50396f9 > > > Diff: https://reviews.apache.org/r/69515/diff/3/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
